Implement npm workspaces #1653
Closed
Implement npm workspaces #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihovil Ilakovac <[email protected]>
infomiho
commented
Jan 21, 2024
| @@ -181,27 +166,3 @@ installProjectNpmDependencies messagesChan projectDir = | |||
| case J._data jobMsg of | |||
| J.JobOutput {} -> printJobMessagePrefixed jobMsg >> processMessages chan | |||
| J.JobExit {} -> return () | |||
|
|
|||
| installWebAppAndServerNpmDependencies :: | |||
There was a problem hiding this comment.
Since the project root npm install handles all of the subpackages we define, no need to run separate npm install for the subpackages.
|
Outdated PR, the main benefit of this PR is for future reference when we decide to explore workspaces again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some issues with duplicate package installations and resolution issues since we are effectively managing multiple packages e.g. sdk, web app and server.
npmhas a feature calledworkspacesthat solves the issue of multiple packages having deps that they need: https://docs.npmjs.com/cli/v8/using-npm/workspacesSpecifying our packages in the
workspacesfield, and running a singlenpm installin the root of the project achieves the following:node_modulesin the root of the projectreactin the root dir and in the web app dirnpm installhas to be run only in one folder i.e. project rootWarning
I've tested out this locally and it worked for me with the prototype. This should be tested more with different fail cases we had. Also,
wasp buildshould be tested as well.