-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enable LeakSanitizer in bindings-rust-asan #820
Conversation
circle.yml
Outdated
@@ -691,7 +691,7 @@ jobs: | |||
command: | | |||
export RUSTFLAGS="-Z sanitizer=address -C opt-level=0" | |||
export RUSTDOCFLAGS=$RUSTFLAGS | |||
cargo +nightly test --target x86_64-unknown-linux-gnu | |||
ASAN_OPTIONS=detect_leaks=1 cargo +nightly test --target x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with introducing a leak: https://app.circleci.com/pipelines/github/wasmx/fizzy/6898/workflows/fa937f8b-c3b3-4291-bbb3-2550ab9d2e94/jobs/62254
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 99.10% 99.10% -0.01%
==========================================
Files 86 86
Lines 13017 13015 -2
==========================================
- Hits 12900 12898 -2
Misses 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As feared the leak sanitizer is on by default now: https://app.circleci.com/pipelines/github/wasmx/fizzy/6907/workflows/0618375e-8c94-495c-8477-8f7ed74f9521/jobs/62402 |
It seems to be on-by-default, also suggested by https://clang.llvm.org/docs/LeakSanitizer.html. |
Part of #614.