Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade uvwasi to 0.0.12 #802

Merged
merged 3 commits into from
May 16, 2022
Merged

Upgrade uvwasi to 0.0.12 #802

merged 3 commits into from
May 16, 2022

Conversation

axic
Copy link
Member

@axic axic commented Nov 19, 2021

This allows removing two workarounds needed for earlier uvwasi versions.

@axic axic changed the title Upgrade to uvwasi 0.0.12 Upgrade uvwasi to 0.0.12 Nov 19, 2021
@axic
Copy link
Member Author

axic commented Nov 19, 2021

Damn:

[53/55] Linking C static library _deps/libuv-build/libuv_a.a
[54/55] Linking C static library libuvwasi_a.a
[55/55] Linking C shared library libuvwasi.so
FAILED: libuvwasi.so 
: && /usr/bin/cc -fPIC    -shared -Wl,-soname,libuvwasi.so -o libuvwasi.so CMakeFiles/uvwasi.dir/src/clocks.c.o CMakeFiles/uvwasi.dir/src/fd_table.c.o CMakeFiles/uvwasi.dir/src/path_resolver.c.o CMakeFiles/uvwasi.dir/src/poll_oneoff.c.o CMakeFiles/uvwasi.dir/src/uv_mapping.c.o CMakeFiles/uvwasi.dir/src/uvwasi.c.o CMakeFiles/uvwasi.dir/src/wasi_rights.c.o CMakeFiles/uvwasi.dir/src/wasi_serdes.c.o  _deps/libuv-build/libuv_a.a  -lpthread  -ldl  -lrt && :
/usr/bin/ld: _deps/libuv-build/libuv_a.a(threadpool.c.o): relocation R_X86_64_32S against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(uv-common.c.o): relocation R_X86_64_32S against `.data' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(uv-data-getter-setters.c.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(core.c.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(fs.c.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(process.c.o): relocation R_X86_64_32S against `.rodata.cst8' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(random-devurandom.c.o): relocation R_X86_64_32S against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(signal.c.o): relocation R_X86_64_32S against `.data' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(stream.c.o): relocation R_X86_64_32S against `.rodata.cst16' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(tcp.c.o): relocation R_X86_64_32S against `.rodata.cst8' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(thread.c.o): relocation R_X86_64_32S against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(tty.c.o): relocation R_X86_64_32S against `.data' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(udp.c.o): relocation R_X86_64_32S against symbol `in6addr_any@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(proctitle.c.o): relocation R_X86_64_32S against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(linux-core.c.o): relocation R_X86_64_32S against `.data' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(epoll.c.o): relocation R_X86_64_32S against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: _deps/libuv-build/libuv_a.a(random.c.o): warning: relocation in read-only section `.text'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

It builds on macOS 😞

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #802 (349d82c) into master (600ca56) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 349d82c differs from pull request most recent head 514df4f. Consider uploading reports for the commit 514df4f to get more accurate results

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   99.12%   99.10%   -0.02%     
==========================================
  Files          81       81              
  Lines       12985    12934      -51     
==========================================
- Hits        12871    12818      -53     
- Misses        114      116       +2     
Flag Coverage Δ
rust 99.90% <ø> (ø)
spectests ?
unittests ?
unittests-32 99.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/wasi/uvwasi.cpp 57.89% <100.00%> (-11.34%) ⬇️
test/testfloat/testfloat.cpp 95.86% <0.00%> (-1.38%) ⬇️
test/unittests/execute_floating_point_test.cpp 99.70% <0.00%> (-0.02%) ⬇️
lib/fizzy/execute.cpp 99.29% <0.00%> (-0.01%) ⬇️
test/unittests/instantiate_test.cpp 100.00% <0.00%> (ø)
test/unittests/floating_point_utils_test.cpp 100.00% <0.00%> (ø)

@axic axic force-pushed the uvwasi branch 3 times, most recently from 8743122 to 4e4c9f2 Compare May 16, 2022 10:53
@axic axic marked this pull request as ready for review May 16, 2022 11:09
@axic axic requested review from gumb0 and chfast May 16, 2022 11:09
@axic axic merged commit a6484cf into master May 16, 2022
@axic axic deleted the uvwasi branch May 16, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants