Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Avoid dead host functions #671

Merged
merged 1 commit into from
Dec 3, 2020
Merged

test: Avoid dead host functions #671

merged 1 commit into from
Dec 3, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Dec 1, 2020

Replace host functions not being executed with null pointers or common functions. Code coverage is happy.

@chfast chfast requested review from gumb0 and axic December 1, 2020 21:11
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #671 (a04c5b4) into master (217c084) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   99.18%   99.29%   +0.10%     
==========================================
  Files          71       71              
  Lines        9741     9739       -2     
==========================================
+ Hits         9662     9670       +8     
+ Misses         79       69      -10     
Flag Coverage Δ
spectests 91.46% <ø> (ø)
unittests 99.29% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/capi_test.cpp 100.00% <100.00%> (+0.95%) ⬆️
test/unittests/execute_control_test.cpp 99.46% <100.00%> (+1.04%) ⬆️
test/unittests/instantiate_test.cpp 100.00% <100.00%> (+0.97%) ⬆️

@chfast chfast force-pushed the test_dead_host_functions branch from 2570ac8 to a04c5b4 Compare December 1, 2020 21:18
@chfast chfast merged commit ed0c522 into master Dec 3, 2020
@chfast chfast deleted the test_dead_host_functions branch December 3, 2020 19:09
@gumb0 gumb0 mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants