cmake: Add fizzy::fizzy-internal INTERFACE library #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 61 61
Lines 8959 8959
=======================================
Hits 8838 8838
Misses 121 121 |
gumb0
approved these changes
Sep 24, 2020
chfast
force-pushed
the
public_capi
branch
2 times, most recently
from
266a792 to
98a135c
Compare
chfast
force-pushed
the
cmake_fizzy_internal
branch
from
f4e8fe1 to
b007b09
Compare
axic
approved these changes
Sep 30, 2020
chfast
force-pushed
the
cmake_fizzy_internal
branch
from
b007b09 to
b41b00b
Compare
The fizzy::fizzy-internal links fizzy::fizzy library with access to internal headers.
chfast
force-pushed
the
cmake_fizzy_internal
branch
from
b41b00b to
1b7ca6f
Compare
Instead of including the directory with internal headers directly.
chfast
force-pushed
the
cmake_fizzy_internal
branch
from
1b7ca6f to
2ec9d1a
Compare
axic
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fizzy::fizzy-internal links fizzy::fizzy library with access to internal headers. Do not include the directory with internal headers directly in test tools.
The tendency should be to migrate from using
fizzy::fizzy-internaltofizzy::fizzyas we get more public API. Ideally, in the end onlyfizzy-unittestsshould be usingfizzy::fizzy-internal.Dependencies are getting messy.
