Run shellcheck #537
Merged
Run shellcheck #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Sep 21, 2020
circle.yml
Outdated
| @@ -1,5 +1,8 @@ | |||
| version: 2.1 | |||
|
|
|||
| orbs: | |||
| shellcheck: circleci/[email protected] | |||
There was a problem hiding this comment.
This is actually just a pip package, we should include it in cpp-build-env and make it part of the lint step.
There was a problem hiding this comment.
Not a pip package, but added to cpp-build-env:15-lint and cpp-build-env:15-clang-10.
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 58 58
Lines 8765 8765
=======================================
Hits 8655 8655
Misses 110 110 |
chfast
approved these changes
Sep 24, 2020
axic
force-pushed
the
shellcheck
branch
3 times, most recently
from
8db4920 to
74e769b
Compare
chfast
reviewed
Sep 24, 2020
circle.yml
Outdated
| - run: | ||
| name: "Run shellcheck" | ||
| command: | | ||
| git ls-files '*.sh' | xargs shellcheck --external-sources |
There was a problem hiding this comment.
Yes, I checked it with removing one quote from apply_patches.sh.
chfast
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/koalaman/shellcheck.
Should consider just installing shellcheck and not using the orb.