ci: Combine linter/style/tidy/portability checks #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 54 54
Lines 17322 17322
=======================================
Hits 17270 17270
Misses 52 52 |
axic
reviewed
Sep 4, 2020
| @@ -17,7 +14,7 @@ executors: | |||
| - image: ethereum/cpp-build-env:14-gcc-10 | |||
| linux-clang-latest: | |||
| docker: | |||
| - image: ethereum/cpp-build-env:14-clang-10 | |||
| - image: ethereum/cpp-build-env:15-clang-10 | |||
There was a problem hiding this comment.
What is the update in 15? Why not update the others for consistency too?
There was a problem hiding this comment.
I only updated this one to include clang-format.
axic
reviewed
Sep 4, 2020
| @@ -304,13 +304,13 @@ jobs: | |||
| sanitizers-macos: | |||
| executor: macos | |||
| environment: | |||
| BUILD_TYPE: RelWithDebInfo | |||
| CMAKE_OPTIONS: -DENABLE_ASSERTIONS=ON -DSANITIZE=address,undefined,nullability,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation | |||
| UBSAN_OPTIONS: halt_on_error=1 | |||
There was a problem hiding this comment.
This is not a build, but runtime parameter, hence not move under build settings?
There was a problem hiding this comment.
It must be the environment variable anyway (libubsan checks it), so this way of setting it is fine.
axic
reviewed
Sep 4, 2020
| @@ -440,7 +441,6 @@ workflows: | |||
| requires: | |||
| - sanitizers-macos | |||
| - coverage | |||
| - cxx20 | |||
There was a problem hiding this comment.
You did not remove the cxx20 task above. Should it be kept?
This moves clang-tidy checking and C++20 build to "lint" job.
axic
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves clang-tidy checking and C++20 build to "lint" job.
The
-Weverythingbuild will be added to "lint" too in #508.