Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Coverage with GCC #519

Merged
merged 2 commits into from
Sep 9, 2020
Merged

ci: Coverage with GCC #519

merged 2 commits into from
Sep 9, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Sep 4, 2020

I'd like to switch to using GCC for line-based coverage. The Clang source-based coverage will stay but will not be used on codecov.

There are two issues with Clang: it has some bugs (e.g. https://codecov.io/gh/wasmx/fizzy/src/3b19fb019b2d204ebe4cb7256d0cfb5db318b78e/lib/fizzy/parser.cpp#L155) and in the source-based coverage to line-based coverage conversion the comments are also marked as executed. The later screws the line count stats.

The plan is to prepare LCOV summary of the coverage on CI and only upload this single file (similarly to what we currently do with Clang).

@chfast
Copy link
Collaborator Author

chfast commented Sep 4, 2020

I'm getting nice results locally, but something does not work on CI (maybe because of different build dir location).

@chfast chfast force-pushed the coverage_gcc branch 6 times, most recently from 4476b4a to 913fd55 Compare September 7, 2020 16:43
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #519 into master will decrease coverage by 0.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   99.70%   98.73%   -0.98%     
==========================================
  Files          54       54              
  Lines       17362     8695    -8667     
==========================================
- Hits        17311     8585    -8726     
- Misses         51      110      +59     

@chfast chfast marked this pull request as ready for review September 7, 2020 17:02
@chfast chfast requested review from axic and gumb0 September 7, 2020 17:02
@axic
Copy link
Member

axic commented Sep 9, 2020

I like the idea, but the codecov link still displays weird results, the files are missing most of the code lines and have empty lines instead (for example execute.cpp).

@axic axic merged commit 2937d9b into master Sep 9, 2020
@axic axic deleted the coverage_gcc branch September 9, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants