Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to switch to using GCC for line-based coverage. The Clang source-based coverage will stay but will not be used on codecov.
There are two issues with Clang: it has some bugs (e.g. https://codecov.io/gh/wasmx/fizzy/src/3b19fb019b2d204ebe4cb7256d0cfb5db318b78e/lib/fizzy/parser.cpp#L155) and in the source-based coverage to line-based coverage conversion the comments are also marked as executed. The later screws the line count stats.
The plan is to prepare LCOV summary of the coverage on CI and only upload this single file (similarly to what we currently do with Clang).