-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle host functions in the instruction executor #1041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the instruction executor to be non-generic for most instruction execution implementations while also allowing host function call instruction implementations to move into the executor in a later commit.
There are still bugs with this commit that need to be fixed.
This change provides roughly the same overall performance (according to our benchmarks) as before the refactoring of the executor which serves as a decent starting point for further optimizations.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 80.86% 80.70% -0.17%
==========================================
Files 271 268 -3
Lines 24896 24964 +68
==========================================
+ Hits 20132 20146 +14
- Misses 4764 4818 +54 ☔ View full report in Codecov by Sentry. |
Robbepop
added a commit
that referenced
this pull request
May 23, 2024
This was an oversight in #1041.
Robbepop
added a commit
that referenced
this pull request
May 23, 2024
* unpack ResumableHostError for non-resumeble calls This was an oversight in #1041. * add doc note * add docs to ResumableHostError fields * apply rustfmt * fix clippy warnings * fix clippy issues in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #970
This makes use of the non-generic
StoreInner
where possible and only uses the genericStore<T>
where needed.count_until
of up to 30% but on average by 4-5%.