Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume table syntax #10

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Resume table syntax #10

merged 4 commits into from
Aug 23, 2024

Conversation

dhil
Copy link
Member

@dhil dhil commented Aug 5, 2024

This patch updates the handwritten wat/wast programs to use the new resume table syntax.

@dhil dhil requested a review from frank-emrich August 5, 2024 09:49
@frank-emrich
Copy link
Contributor

This fails currently because wasm-merge does not support the new syntax, yet. I will create a PR with binaryen this week to change the syntax there.

@frank-emrich
Copy link
Contributor

The new syntax has landed in binaryen now, and I've updated the harness to use a more recent binaryen, wasmtime, and reference interpreter.

There's also some weirdness about the preprocessor inserting lines starting with # to mark where it did something. In the past they only appeared in the beginning of imports.wat.pp, but now they appear elsewhere. I've switched to just sed-ing all of these lines away. We probably need to do the same in other Makefiles, too.

@frank-emrich frank-emrich merged commit f899816 into main Aug 23, 2024
2 checks passed
@frank-emrich frank-emrich deleted the resumetables branch August 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants