Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access to php integration test secrets #5007

Merged

Conversation

barankaraaslan
Copy link
Contributor

these env vars are required for running soon to be enabled php tests

@barankaraaslan barankaraaslan requested a review from xdoardo August 12, 2024 17:59
@barankaraaslan barankaraaslan force-pushed the sre-383-re-enable-ignored-integration-test-test_php_extensions branch 2 times, most recently from ac209ff to 5614daf Compare August 12, 2024 21:37
@xdoardo
Copy link
Contributor

xdoardo commented Aug 13, 2024

While it does not strictly concern this PR, we should note that the CI test test-sys / Build and test C-API on macos-x64 (pull_request) failed - I think re-running it might pass - but also printed this warning:

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Error: The operation was canceled.

edit: again, not strictly related to this PR but integration tests testing deployments fail with

It seems you don\'t have access to wasmer-integration-tests
error: Please, change the owner before deploying or check your current user with `wasmer whoami`.

Perhaps there's something off with the token we pass in the env?

@barankaraaslan barankaraaslan force-pushed the sre-383-re-enable-ignored-integration-test-test_php_extensions branch 5 times, most recently from af4b968 to e522093 Compare August 14, 2024 17:19
@barankaraaslan barankaraaslan force-pushed the sre-383-re-enable-ignored-integration-test-test_php_extensions branch from e522093 to 4d90637 Compare August 14, 2024 17:20
@theduke theduke merged commit ea574cf into main Aug 15, 2024
62 of 64 checks passed
@theduke theduke deleted the sre-383-re-enable-ignored-integration-test-test_php_extensions branch August 15, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants