Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement wasmer whoami #3316
Implement wasmer whoami #3316
Changes from 12 commits
9d7ed9e
3bb8ffd
33a2585
edf32a7
fff2917
1d6dd0d
8644fc2
f26ccf8
8dfe8da
e9048b9
6141043
7e304ec
04eda8d
0e9ff36
fd8e321
cb3096a
9beaf8e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this test is a good idea.
It assumes the
$WAPM_DEV_TOKEN
variable is set and that user's name isciuser
, so the only way for integration tests to pass locally is if you have theciuser
token on your computer, which is a massive no-no (no human developers should have access to CI tokens).We're also trying to contact wapm.dev, which makes the test slow and flaky (e.g. wapm.dev could be having a bad day and always error out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah well with network requests, that's kind of a given, otherwise it wouldn't be an integration test. In the worst case the test fails because wapm.dev is down, then we just need to restart the tests on GitHub.
The other part, I think I can require
WAPM_DEV_TOKEN
ifGITHUB_TOKEN
is present (true for integration tests in the CI, false for running tests locally).