Regression test for #2721 #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wasm snippet in the test corresponds to roughly: ```rust let name = "bananapeach"; banana(a, b, c, name.len() as _, name.as_ptr() as _, f, g, h); ``` however sometime between 2.0 and 2.1 the name pointer is no longer being passed through as an argument. Instead a 0 gets passed in. To make things weirder, if `name.as_ptr()` is passed through multiple times, the second time the pointer will get passed correctly.
`/usr/bin/bash` is not really universal way to invoke the bash shell. `/usr/bin/env bash` is more appropriate.
syrusakbary
approved these changes
Dec 14, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm snippet in the test corresponds to roughly:
however sometime between 2.0 and 2.1 the name pointer is no longer being
passed through as an argument. Instead a 0 gets passed in.
To make things weirder, if
name.as_ptr()is passed through multipletimes, the second time the pointer will get passed correctly.
The fix for this issue is in #2723.