Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test showing issue with reusing import objects w/ WasmerEnv #1876

Closed
wants to merge 1 commit into from

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Dec 4, 2020

Run

cargo test --release --features "cranelift singlepass" --features "test-cranelift test-jit" -- multi_use_host_fn_manages_memory_correctly --nocapture

to reproduce the bug.

notice that the dbg! line is called twice, this means the env is being init'd twice, (it won't do anything the second time, so the second instance will see the wrong Memory)

This bug is being fixed in #1865

Review

  • Add a short description of the the change to the CHANGELOG.md file

@MarkMcCaskey
Copy link
Contributor Author

This was fixed and this test case added in #1865

@MarkMcCaskey MarkMcCaskey deleted the feature/wasmer-env-fix branch December 16, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant