Support for python 3.11 #704
Conversation
ayys
force-pushed
the
run-on-m1-with-python-3.11
branch
2 times, most recently
from
76d793b
to
da52536
Compare
- Adds python 3.11 to Cargo.toml files - Adds tests for python 3.11 in CI
ayys
force-pushed
the
run-on-m1-with-python-3.11
branch
from
da52536
to
af35692
Compare
There was a problem hiding this comment.
Keep in mind that this means we'll forever need to keep Cargo.toml and pyproject.toml in sync. I'd much prefer to use just Cargo.toml instead of a mixture of Cargo.toml and pyproject.toml, and let maturin generate the pyproject.toml.
Release tools like cargo release won't know to bump version numbers in both Cargo.toml and pyproject.toml, so we'll need to keep version numbers in sync manually.
packages/api/pyproject.toml
Outdated
| [project] | ||
| name = "wasmer" | ||
| version = "1.1.0" | ||
| description = "Python extension to run WebAssembly binaries" | ||
| readme = "README.md" | ||
| repository = "https://github.com/wasmerio/wasmer-python" | ||
| keywords = ["python", "extension", "webassembly"] | ||
| categories = ["wasm"] | ||
| build = "build.rs" | ||
|
|
||
| [package] | ||
| edition = "2018" | ||
|
|
||
| [build-system] | ||
| requires = ["maturin>=0.14,<0.15"] | ||
| build-backend = "maturin" | ||
|
|
||
| [tool.maturin.metadata] | ||
| category = ["Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: Implementation :: CPython", | ||
| "Programming Language :: Rust", | ||
| "Topic :: Software Development", | ||
| "Topic :: Software Development :: Compilers", | ||
| "Topic :: Software Development :: Interpreters", | ||
| "License :: OSI Approved :: MIT License", | ||
| "Operating System :: OS Independent"] | ||
|
|
||
|
|
||
| [tool.maturin.project-url] | ||
| "Source Code" = "https://github.com/wasmerio/wasmer-python/" | ||
| "Bug Tracker" = "https://github.com/wasmerio/wasmer-python/issues" | ||
| "Documentation" = "https://github.com/wasmerio/wasmer-python/" |
There was a problem hiding this comment.
Keep in mind that this means we'll forever need to keep Cargo.toml and pyproject.toml in sync. I'd much prefer things like keywords, version number, description, and so on are specified in Cargo.toml so we only need to manage one file per package.
This also makes releases more annoying because release tools like cargo release won't know to update the version number in both files.
There was a problem hiding this comment.
I've this this issue by removing the project section from pyproject.toml. This means the version will only need to be updated in Cargo.toml.
|
I've upadted the description with the issues. #657 isn't fixed by this PR, but the others are. |
|
Hello, first of all, thank you for the great work! |
|
@ayys @Michael-F-Bryan Sorry for bothering but I'd appreciate if you could check my question. |
This PR is to make wasmer-python run with support for python 3.11
I also wanted to get wasmer-python working on M1 as well, but could not get llvm to compile. That should probably be a separate PR anyway since this one is fixing too many things already.