Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweak and documentation to build wasmer-python #681

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

brunokim
Copy link
Contributor

@brunokim brunokim commented Jan 4, 2023

##What

  • Add specific version to maturin dep
  • Call out that LLVM 12.0 is required to build all compilers

Why

maturin broke their command-line options with v0.13 (see changelog), preventing just build api from working.

Notes

I've tried at first to install LLVM 12.0.1 using llvmenv, but there were some missing headers in Ubuntu 🤷 Using llvm.sh was the best option to getting everything at once. I've also had to set the LLVM_SYS_120_PREFIX env variable to $(llvm-config-12 --prefix)

2 tests failed citing the lack of clang, is this a required component for further development?

FAILED tests/test_docs.py::test_doctest[<module 'target'>0] - pyo3_runtime.PanicException: Need at least one of `clang-11`, `clang-10`, or `clang` installed in order to use `DylibEngine` when cross-compiling
FAILED tests/test_docs.py::test_doctest[<module 'target'>1] - pyo3_runtime.PanicException: Need at least one of `clang-11`, `clang-10`, or `clang` installed in order to use `DylibEngine` when cross-compiling

@syrusakbary syrusakbary merged commit 1f2f0a5 into wasmerio:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants