feat(module) Introduce the Module class
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch creates the `Module` class, with so far a single static method `validate`.
This patch implements 2 methods on `Module`: 1. `__init__`, i.e. the constructor, i.e. the famous “module.compile” method, 2. `instantiate` to instantiate a module.
Hywan
added
🎉 enhancement
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 11, 2019
47: feat(module) Introduce the `Module` class r=Hywan a=Hywan The `Module` class provides: 1. `__init__` to compile a sequence of bytes into a WebAssembly module, 2. `instantiate` to instantiate a module (and get an `Instance` object), 3. `validate` —a static method— to check whether the given bytes represent a valid WebAssembly module. Co-authored-by: Ivan Enderlin <[email protected]>
Build succeeded |
|
This is great!! |
This was referenced Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Moduleclass provides:__init__to compile a sequence of bytes into a WebAssembly module,instantiateto instantiate a module (and get anInstanceobject),validate—a static method— to check whether the given bytes represent a valid WebAssembly module.