feat(instance,module) Improve error messages #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 12, 2019
42: feat(instance,module) Improve error messages r=Hywan a=Hywan Fix #41. These patches improve error messages when instantiating a module with `Module.Instantiate` or with `NewInstance`. The error message that is returned by `Module.Instantiate` isn't very helpful, but it's going to change with wasmerio/wasmer#493. Let's wait the next release of the runtime! Co-authored-by: Ivan Enderlin <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41.
These patches improve error messages when instantiating a module with
Module.Instantiateor withNewInstance.The error message that is returned by
Module.Instantiateisn't very helpful, but it's going to change with wasmerio/wasmer#493. Let's wait the next release of the runtime!