Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input field label autocomplete bug fix #289

Merged
merged 7 commits into from
Dec 14, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update readme
  • Loading branch information
atomictangerine committed Dec 12, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit e1d1640eda955cdfe217056d2026900b26344031
4 changes: 2 additions & 2 deletions ui/input-text/README.md
Original file line number Diff line number Diff line change
@@ -33,10 +33,10 @@ Approaches we can take:

From all the possible approaches, we opted to go with listening to the animation. This solution was adapted from a [solution Klarna UI](https://medium.com/@brunn/detecting-autofilled-fields-in-javascript-aed598d25da7) has used in the past.

To start, we had to add the animation on the autofill pseudo selectors. So we created two animations and then called them inside the autofill selectors. Note: We need to add these animations to the globalStyles because stitches will change the class names and we won't be able to match them inside of our component.
To start, we had to add the animation on the autofill pseudo selectors. We created two animations and called them inside the autofill selectors. Note: We need to add these animations to the globalCss because stitches will change the class names and we won't be able to match them inside of our component. We couldn't just add them to globalStyles, however, because not all teams have adopted and/or are using our global styles.

```js
export const globalStyles = globalCss({
export const globalJsTriggerAnimations = globalCss({
"@keyframes jsTriggerAutoFillStart": {
from: {
alpha: 1,