Drawer #190
Merged
Drawer #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artmsilva
reviewed
Aug 26, 2022
ui/drawer/package.json
Outdated
| { | ||
| "name": "@washingtonpost/wpds-drawer", | ||
| "version": "0.13.0", | ||
| "description": "> TODO: description", |
There was a problem hiding this comment.
Can we update this field?
There was a problem hiding this comment.
updated in e6cf4e6
artmsilva
reviewed
Aug 29, 2022
artmsilva
approved these changes
Aug 30, 2022
| type DrawerCloseProps = React.ComponentPropsWithRef<typeof CloseButton> & { | ||
| sticky?: boolean; | ||
| /** @default compact */ | ||
| density?: "default" | "compact"; |
There was a problem hiding this comment.
not a blocker, but how do you feel about using enums for these? That way we can avoid user spelling mistakes
There was a problem hiding this comment.
For a simple case like this an enum doesn't feel necessary. The union of string literals will provide completions and throw errors for typos.
Maybe for creating more understandable values or something that needs to be iterated, otherwise enums feel cumbersome.
atomictangerine
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR adds a Drawer component, based on the initial v0 implementation
API Changes
DrawerRoot
DrawerTrigger
data-qaprop directlyDrawerContent
Component Structure
Drawer favors splitting sub-components into individual files and the inclusion of unit tests for these files