fix: input field label autocomplete bug fix #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomictangerine
requested review from
artmsilva,
clairehhelms and
wp-aberg
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artmsilva
requested changes
Dec 10, 2022
atomictangerine
commented
Dec 12, 2022
ui/input-text/src/InputText.tsx
Outdated
| @@ -135,16 +139,55 @@ export const InputText = React.forwardRef<HTMLInputElement, InputTextProps>( | |||
| }, | |||
| ref | |||
| ) => { | |||
| const [helperId, setHelperId] = React.useState<string | undefined>(); | |||
| const [errorId, setErrorId] = React.useState<string | undefined>(); | |||
| globalJsTriggerAnimations(); | |||
There was a problem hiding this comment.
Explicitly calling our trigger animations here. The animations have to be in globalCss in order for them to not lose their names. Creating the animations inside the component did not work, not as a const as recommended by the Stitches API, when inside the unstyledInput styles, etc. since Stitches changes the class names. Also followed this pattern in TextArea. This also means that the styles will be applied even if our globalStyles are not being used.
artmsilva
requested changes
Dec 12, 2022
artmsilva
reviewed
Dec 12, 2022
wp-aberg
reviewed
Dec 12, 2022
artmsilva
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Input field label autocomplete bug fix