Skip to content

Commit

Permalink
feat: update to node 16 (#123)
Browse files Browse the repository at this point in the history
* chore: update to node lts/gallium

* chore: update turbo

* chore: update swc

* chore: update next

* chore: update codesandbox ci to 16
  • Loading branch information
artmsilva authored Jun 21, 2022
1 parent e9e0e8f commit 51083ec
Show file tree
Hide file tree
Showing 14 changed files with 36,870 additions and 38,092 deletions.
2 changes: 1 addition & 1 deletion .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"sandboxes": ["new", "/app", "next.js"],
"node": "14"
"node": "16"
}
1 change: 0 additions & 1 deletion .github/workflows/chromatic-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:

- name: Install npm dependencies
run: |
npm i -g [email protected]
npm ci
lerna bootstrap --hoist
npx lerna link --force-local
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/experimental-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:

- name: Install npm dependencies
run: |
npm i -g [email protected]
npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/latest-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:

- name: Install npm dependencies
run: |
npm i -g [email protected]
npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:

- name: Install npm dependencies
run: |
npm i -g [email protected]
npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.18.2
lts/gallium
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ building-storybook:
npx build-storybook --output-dir ./app/public/storybook --preview-url /storybook/iframe.html --force-build-preview --quiet

all-dev:
npx concurrently -n 'workspaces,playroom,storybook,website' 'npm run watch --workspaces' 'npm run playroom:start' 'make localdev-storybook-in-nextjs' 'npm run website:dev'
npx concurrently -n 'workspaces,storybook,website' 'npm run watch --workspaces' 'make localdev-storybook-in-nextjs' 'npm run website:dev'

start-storybook:
start-storybook -p 6006 --quiet --ci
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@next/bundle-analyzer": "^12.0.7",
"@washingtonpost/wpds-assets": "^1.8.1",
"@washingtonpost/wpds-ui-kit": "0.9.1",
"next": "^12.0.4",
"next": "^12.1.6",
"react": "^17.0.2",
"react-dom": "^17.0.2"
},
Expand Down
14 changes: 3 additions & 11 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This project uses the [fork feature](https://docs.github.com/en/get-started/quic

## Develop Locally

We use NVM to manage node versions. Our node version is in the `./nvmrc` file. We use NPM 8.3.0. We also assume you have access to our private org on NPM.
We use NVM to manage node versions. Our node version is in the `./nvmrc` file. We also assume you have access to our private org on NPM.

Run the following commands to get your local development environment set up.

Expand All @@ -13,27 +13,19 @@ nvm use
```

```shell
npm i -g [email protected]
```

```shell
npm install
npm ci
```

```shell
npm run build
```

We use Storybook to develop locally along with Playroom and Next.js.
We use Storybook to develop locally along with Next.js.

```bash
npm run storybook
```

```shell
npm run playroom:start
```

You can run `npm run dev` to develop and test with the test app.

## Testing
Expand Down
6 changes: 2 additions & 4 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"packages": [
"./ui/*",
"./app"
],
"packages": ["./ui/*", "./app"],
"useWorkspaces": true,
"useNx": false,
"npmClient": "npm",
"command": {
"version": {
Expand Down
Loading

1 comment on commit 51083ec

@vercel
Copy link

@vercel vercel bot commented on 51083ec Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

wpds-ui-kit – ./

wpds-ui-kit.preview.now.washingtonpost.com
wpds-ui-kit-git-main.preview.now.washingtonpost.com

Please sign in to comment.