Updated default parsers to include all embed parsers; updated tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (a few sentences describing the overall goals of the PR's commits)
Recently added embed parsers were not being added to
DefaultHtmlAnsParseras default parsers. This PR adds those parsers to the defaults, adds some comments, addresses a couple of minor style issues, and adds some additional tests totest_html2ans.Steps to Test or Reproduce (outline the steps to test or reproduce the PR here)
Parse a PollDaddy, Reddit, Flickr, etc. embed using the
DefaultHtmlAnsParser/Html2Ansclass and ensure that it comes back as anoembedrather thanraw_html.Todos
Before PR:
Comments (include any comments to help with an effective code review here)