Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wabt-compatibility] bulk memory #51

Merged
merged 4 commits into from
May 27, 2020
Merged

Conversation

duongnhn
Copy link
Contributor

@duongnhn
Copy link
Contributor Author

duongnhn commented May 22, 2020

@ktran @bmeurer @EricSL @yurydelendik PTAL, thanks :)

I don't think we can display name in this case if we want to be wabt-compatibility.

Copy link
Collaborator

@ktran ktran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operands for table.copy & table.init are still in place according to the linked specification.
It's just that the table is omitted if the table index is 0 (for table.copy if both src and dest are 0).

See the core spec, 6.5.6 Table Instructions

@ktran ktran marked this pull request as draft May 25, 2020 05:12
@ktran ktran marked this pull request as ready for review May 25, 2020 05:13
@duongnhn
Copy link
Contributor Author

The operands for table.copy & table.init are still in place according to the linked specification.
It's just that the table is omitted if the table index is 0 (for table.copy if both src and dest are 0).

See the core spec, 6.5.6 Table Instructions

Make senses. Thanks Kim 👍

@duongnhn duongnhn requested a review from ktran May 25, 2020 18:29
Copy link
Collaborator

@ktran ktran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, Z! Just very small nits.

@duongnhn duongnhn requested a review from ktran May 26, 2020 18:41
@duongnhn
Copy link
Contributor Author

duongnhn commented May 26, 2020

@ktran sorry, I clicked something and it request you to review again :(

@ktran ktran merged commit aff8cc3 into wasdk:master May 27, 2020
@ktran
Copy link
Collaborator

ktran commented May 27, 2020

No worries, thanks for the help!

@duongnhn duongnhn deleted the wabt-compatibility branch May 27, 2020 04:38
@yurydelendik
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants