-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wabt-compatibility] bulk memory #51
Conversation
@ktran @bmeurer @EricSL @yurydelendik PTAL, thanks :) I don't think we can display name in this case if we want to be wabt-compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operands for table.copy & table.init are still in place according to the linked specification.
It's just that the table is omitted if the table index is 0 (for table.copy
if both src and dest are 0).
See the core spec, 6.5.6 Table Instructions
Make senses. Thanks Kim 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Z! Just very small nits.
@ktran sorry, I clicked something and it request you to review again :( |
No worries, thanks for the help! |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
According to https://github.com/WebAssembly/bulk-memory-operations/blob/master/proposals/bulk-memory-operations/Overview.md, instructions as table.init, table.copy has changed.
Bug: #33