Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wabt compatibility test #42

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

duongnhn
Copy link
Contributor

As mentioned in #33 and https://bugs.chromium.org/p/chromium/issues/detail?id=1066386, we want to generate WAT that is wabt-compatible.

Some existing ones are not wabt-compatible so we exclude those.

@duongnhn
Copy link
Contributor Author

@bmeurer @ktran PTAL :)

Copy link
Collaborator

@ktran ktran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo Benedikt's comment, thanks!

@yurydelendik yurydelendik merged commit 7050e0b into wasdk:master May 18, 2020
@yurydelendik
Copy link
Collaborator

Thank you for the patch!

@duongnhn duongnhn deleted the wabt-test branch May 18, 2020 18:20
@yurydelendik
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants