Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting wasmparser output to be wat compatible #32

Merged

Conversation

ktran
Copy link
Collaborator

@ktran ktran commented Mar 5, 2020

This set of changes adapts the wasmparser output to be wat compatible, but also includes a few changes that are not explicitly defined in the latest WebAssembly Specification (note that this is the specification for reference_types, since the core specification does not even know about table.copy/table.get).

The change that refers to the linked specification includes:

  • "infinity" -> "inf" (6.3.2 Floating-Point)
  • "get_table" / "set_table" -> "table.get" / "table.get" (6.5.6 Table Instructions)
  • "table.copy $src $dest" -> $table.copy $dest $src" (6.5.6 Table Instructions, 4.4.5 Table Instructions)

The change that is not motivated by the specification includes:

  • "v128.const i32" -> "v128.const i32x4" (motivated by SIMD proposal)
  • "v8x16.shuffle $hex1 .. $hex4" -> "v8x16.shuffle $dec1 .. $dec16" ($hex and $dec being placeholders for the printed numbers (motivated by SIMD proposal)

PTAL :).

@yurydelendik yurydelendik merged commit 5f0f6cb into wasdk:master Mar 5, 2020
@yurydelendik
Copy link
Collaborator

Thank you for the patch.

@yurydelendik
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants