Feature: Add flag for install location (optional)

[ArronaxKP]

This change adds a new flag -i or --install that will allow you to set where the Terraform binary is downloaded/installed into. Useful for edge cases where you need to share commonly installed versions of Terraform.

This is in draft as it is built upon this PRs that should be merged first. To save headaches with merge conflicts this PR already includes that commit.

• Fix binPath when getting latest #295 - Thanks @jukie for the PR.

Once the above PR has been merged ping me and I can update this branch with latest master.

I have created a similar PR for tgswitch here - warrensbox/tgswitch#140

[strowi]

This would be very useful for CI/CD cases where $HOME/ is not a cache-able path.

[ArronaxKP]

For CI/CD is what I wrote this for. It turns out we found a workaround for the issue we were having so I didn't need this in the end.

I created a test binary and published it here if you want it but I am not using it myself, I fell back to the original version by warrensbox. I think its just linux_amd64 binary only though:
https://github.com/ArronaxKP/terraform-switcher/releases/tag/tfswitch-with-install-flag

[warrensbox]

We can revisit this after release v1.10

[ArronaxKP]

Updated with latest master changes. I have moved away from using tfswitch and tgswitch now. But I wanted to attempt to get this PR updated to as best I can. Since I haven't touched this project in over 9 months, it took a while. I "think" it now works. I tested locally quickly and the -i install works however I am using windows so not a real test. I don't have time to fully test it on all platforms.

If this is still wanted please ping me if you need anything. I will leave this PR in draft as I cannot fully test this locally. Feel free to take the code and create a new branch/PR if that is easier.

GitHub actions now pass for me:

[yermulnik]

Thank you for re-visiting this PR.
I do hope you won't be much distracted by re-visiting it once again once the #356 is merged — the #356 brings a lot of refactoring, including the bits touched in this PR.
Thanks in advance.

[ArronaxKP]

Resolved all comments.

If you ping me when #356 is merged. I will update this again, and re-test it.

[yermulnik]

Resolved all comments.

Thank you.

If you ping me when #356 is merged. I will update this again, and re-test it.

We'll try out best 🤝

[yermulnik]

If you ping me when #356 is merged. I will update this again, and re-test it.

We'll try out best 🤝

@ArronaxKP Pinging you

[ArronaxKP]

As promised the PR updated with latest master. Includes the origina -i/--install flag changes.

Spotted some other warnings in other files I thought I would fix.

• Moved homedir function to the files.go file inline with all other file functions.
• Fixed markdown spacing issues where there was a missing new line between headers and bullet points.
• Corrected some warnings for booleans based on best practice:
  • S1008 - Simplify returning boolean expression.
  • S1002 - Omit comparison with boolean constant.

My github actions are successful:

[yermulnik]

LGTM with minor note below

[yermulnik]

Also please fetch master

[yermulnik]

@warrensbox @MatrixCrawler @crablab @MatthewJohn @jukie Please review.

[ArronaxKP]

Updated with latest master. My Github actions is passing as well

[MatrixCrawler]

LGTM

[crablab]

Will look this evening/tomorrow morning.

[yermulnik]

Will look this evening/tomorrow morning.

I'm giving this my "LGTM". Please merge once you get this reviewed and if you approve when you have a chance later. Thanks.