Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Downloads Checksum & Signature #160

Closed
markmsmith opened this issue Apr 26, 2021 · 0 comments · Fixed by #334
Closed

Verify Downloads Checksum & Signature #160

markmsmith opened this issue Apr 26, 2021 · 0 comments · Fixed by #334
Assignees
Labels
documentation Add or improve documentation: README/CHANGELOG/comments on code enhancement Refactor existing code for better performance and quality new feature New feature or request

Comments

@markmsmith
Copy link

Due to the increasing frequency of supply chain attacks, it would be nice if tfswitch verified the checksums and gpg signatures of terraform when it downloads it for the first time, as described here:
https://www.hashicorp.com/security#template-page-security:~:text=Release%20Archive%20Checksum%20Verification

Here's some example bash code that may provide a useful starting point for doing the equivalent in Go:
https://gist.github.com/markmsmith/cda59d5f24a812bea66fb3dbd7612397

@MatrixCrawler MatrixCrawler added the new feature New feature or request label Mar 27, 2024
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Mar 27, 2024
@MatrixCrawler MatrixCrawler added documentation Add or improve documentation: README/CHANGELOG/comments on code enhancement Refactor existing code for better performance and quality labels Mar 27, 2024
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Mar 28, 2024
@MatrixCrawler MatrixCrawler self-assigned this Mar 28, 2024
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Mar 28, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Mar 28, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Mar 28, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Apr 2, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Apr 3, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Apr 3, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Apr 3, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Apr 5, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit to MatrixCrawler/terraform-switcher that referenced this issue Apr 5, 2024
…warrensbox#290

- added github action for testing
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- update changelog and readme
MatrixCrawler added a commit that referenced this issue Apr 5, 2024
Co-authored-by: George L. Yermulnik <[email protected]>

- implemented check for signature and checksums for #160 and #290
- added test for checksum matching
- add gitattributes for windows testing. if not present the lf line endings will be converted to crlf which messes with the checksum tests.
- make public key options configurable via command line
- delete hash files after checking the signatures and checksums
- remove obsolete go.yml which is replaced with build.yml
- move default values into defaults.go
- replace unnecessary function calls with defer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add or improve documentation: README/CHANGELOG/comments on code enhancement Refactor existing code for better performance and quality new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants