Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: add Hindi translation #387

Merged

Conversation

prajwalhaniya
Copy link
Contributor

@prajwalhaniya prajwalhaniya commented Feb 19, 2023

Adds Hindi translation.

@warpdesign warpdesign changed the title translation-done, conflict resolved Localization: add Hindi translation Feb 19, 2023
Copy link
Owner

@warpdesign warpdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Unfortunately a few translations appear to be missing from hi.json when compared to the base language en.json. For example:

"SORT_ASCENDING": "Ascending",
"SORT_DESCENDING": "Descending"

image

To verify you can check the number of lines of en.json & hi.json: both files should have the same number of lines.

Copy link
Owner

@warpdesign warpdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: thank you!

@warpdesign warpdesign merged commit a473ac1 into warpdesign:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants