Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#497): default validity to empty object, set interaction validity before using it when updating interaction call #503

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

dtfiedler
Copy link
Contributor

@dtfiedler dtfiedler commented Jan 26, 2024

The log below shows that validity can be undefined when returning from cache, resulting in the errors described in #497. Additionally, moves setting interaction validity before acccessing it below in interactionCall.update().

2024-01-26T17:56:55.903Z DEBUG [HandlerBasedContract] Cached state [
  SortKeyCacheResult {
    sortKey: '000001351346,0000000000000,b407f22dec983a4bcaf4a867605ed09aef711cb038eaa49161c7d9a4e17e1661',
    cachedValue: { state: [Object], validity: undefined, errorMessages: {} }
  },
  undefined
]

@dtfiedler dtfiedler changed the title fix(#497): set validty before using it when updating interaction call fix(#497): set validty before using it when updating interaction call, default to empty object Jan 26, 2024
@dtfiedler dtfiedler changed the title fix(#497): set validty before using it when updating interaction call, default to empty object fix(#497): default validity to empty object, set interaction validity before using it when updating interaction call Jan 26, 2024
@ppedziwiatr ppedziwiatr merged commit 51f5063 into warp-contracts:main Jan 31, 2024
@dtfiedler dtfiedler deleted the patch-4 branch January 31, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants