pmd: revert #3014 and drain extensions before next ssl read

warmcat · Nov 24, 2023 · 8d40798 · 8d40798
1 parent cd6ce19
commit 8d40798
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/lib/roles/ws/ops-ws.c b/lib/roles/ws/ops-ws.c
@@ -723,7 +723,7 @@ lws_ws_rx_sm(struct lws *wsi, char already_processed, unsigned char c)
 			}
 
 #if !defined(LWS_WITHOUT_EXTENSIONS)
-			if (!lin && !(already_processed & ALREADY_PROCESSED_FULL_DRAINING))
+			if (!lin)
 				break;
 #endif
 
@@ -1223,8 +1223,18 @@ rops_handle_POLLIN_ws(struct lws_context_per_thread *pt, struct lws *wsi,
 		else
 			pending = pending > wsi->a.context->pt_serv_buf_size ?
 				wsi->a.context->pt_serv_buf_size : pending;
-		if (--sanity)
+		if (--sanity) {
+#if !defined(LWS_WITHOUT_EXTENSIONS)
+			while (wsi->ws->rx_draining_ext) {
+				// RX Extension needs to be drained before next read
+				n = lws_ws_rx_sm(wsi, ALREADY_PROCESSED_IGNORE_CHAR, 0);
+				if (n < 0) {
+					return LWS_HPI_RET_PLEASE_CLOSE_ME;
+				}
+			}
+#endif
 			goto read;
+		}
 		else
 			/*
 			 * Something has gone wrong, we are spinning...

diff --git a/lib/roles/ws/private-lib-roles-ws.h b/lib/roles/ws/private-lib-roles-ws.h
@@ -75,7 +75,6 @@ enum lws_websocket_opcodes_07 {
 
 #define ALREADY_PROCESSED_IGNORE_CHAR 1
 #define ALREADY_PROCESSED_NO_CB 2
-#define ALREADY_PROCESSED_FULL_DRAINING 4
 
 #if !defined(LWS_WITHOUT_EXTENSIONS)
 struct lws_vhost_role_ws {

diff --git a/lib/roles/ws/server-ws.c b/lib/roles/ws/server-ws.c
@@ -1080,7 +1080,7 @@ lws_parse_ws(struct lws *wsi, unsigned char **buf, size_t len)
 				   wsi->ws->rx_draining_ext);
 #endif
 			m = lws_ws_rx_sm(wsi, ALREADY_PROCESSED_IGNORE_CHAR |
-					      ALREADY_PROCESSED_NO_CB | ALREADY_PROCESSED_FULL_DRAINING, 0);
+					      ALREADY_PROCESSED_NO_CB, 0);
 		}
 
 		if (m < 0) {