-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various clean ups #262
Various clean ups #262
Conversation
@@ -0,0 +1,43 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just warn the user that firewalld, nft, or iptables is running and that it might need to be modified, or actually add the port 80 file for them. We shouldn't disable a firewall on a user especially on ALL and MASTER.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #264 to track this.
%define debug_package %{nil} | ||
|
||
Summary: Tools used for clustering with Warewulf | ||
Name: warewulf-cluster | ||
Version: @PACKAGE_VERSION@ | ||
Release: %{_rel}%{?dist} | ||
Release: 1%{?dist} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you went through and removed %{_rel} we use this in CI.
@@ -12,6 +12,8 @@ URL: http://warewulf.lbl.gov/ | |||
Source: %{name}-%{version}.tar.gz | |||
ExclusiveOS: linux | |||
Requires: warewulf-common warewulf-provision | |||
Requires: nfs-utils | |||
Requires: ntp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't believe "ntp" is available in CentOS8 or Suse15. Reasonably likely that Chrony will be installed on these distros by default even in minimal installs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #265 to add nfs-utils and tcpdump to development.
@@ -33,3 +33,4 @@ fi | |||
fi | |||
done | |||
|
|||
exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you track down what was actually causing this to exit non-zero before?
Some relatively minor fix-ups that I've found for initial install-ability.