Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing unclear docs for configuring magento 2 credentials #512

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fixing unclear docs for configuring magento 2 credentials #512

merged 3 commits into from
Apr 11, 2022

Conversation

Nuuttif
Copy link

@Nuuttif Nuuttif commented Apr 11, 2022

@Nuuttif Nuuttif mentioned this pull request Apr 11, 2022
Closed
@Nuuttif
Copy link
Author

Nuuttif commented Apr 11, 2022 •
edited
Loading

Why do these checks fail? I just changed a few lines in docs and I don't think these changes relate to any errors.

@davidalger davidalger merged commit b4821f5 into wardenenv:develop Apr 11, 2022
@davidalger
Copy link
Collaborator

@Nuuttif Sorry about the failing checks, that's wasn't your issue; fixed that this morning in #514 so the MR here could build and setup the deploy preview for me.

Made one tweak and merged the fix. Thanks for the callout and MR to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuuttif @davidalger