Skip to content

Commit

Permalink
Standardize JSON times to strings
Browse files Browse the repository at this point in the history
Integer times in construction.json were converted directly to minutes
(confirmed in-game that these are the correct construction times).

Integer times in some ammo and vehicle recipes were converted such that
100 is 1 turn, and since 1 turn is 1 second, this means "time: 4000" is
a duration of 40 seconds, and "time: 30000" is a duration of 5 minutes.
Again I checked in-game for these recipes to be sure of my
interpretation (despite a few of these seeming unrealistically quick,
such as the 5-second boat oars).

Partial fix for CleverRaven#36110
  • Loading branch information
wapcaplet committed Jan 26, 2020
1 parent 71ee31c commit 2231d2d
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 28 deletions.
16 changes: 8 additions & 8 deletions data/json/construction.json
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,7 @@
"//": "Fills a deep pit with dirt.",
"category": "CONSTRUCT",
"required_skills": [ [ "fabrication", 0 ] ],
"time": 40,
"time": "40 m",
"qualities": [ [ { "id": "DIG", "level": 1 } ] ],
"components": [ [ [ "material_soil", 200 ] ] ],
"pre_special": "check_empty",
Expand All @@ -867,7 +867,7 @@
"//": "Adds wood chippings to a shallow pit to prevent plants growing, or for looks.",
"category": "CONSTRUCT",
"required_skills": [ [ "fabrication", 0 ] ],
"time": 40,
"time": "40 m",
"components": [ [ [ "splinter", 50 ] ] ],
"pre_terrain": "t_pit_shallow",
"post_terrain": "t_woodchips"
Expand Down Expand Up @@ -910,7 +910,7 @@
"//": "Makes an outside wooden paving, similar to what would be used in patios.",
"category": "CONSTRUCT",
"required_skills": [ [ "fabrication", 1 ] ],
"time": 100,
"time": "100 m",
"qualities": [ [ { "id": "HAMMER", "level": 2 } ] ],
"components": [ [ [ "2x4", 14 ] ], [ [ "nail", 28 ] ] ],
"pre_special": "check_empty",
Expand Down Expand Up @@ -1735,7 +1735,7 @@
"description": "Build Bed Frame",
"category": "FURN",
"required_skills": [ [ "fabrication", 4 ] ],
"time": 55,
"time": "55 m",
"qualities": [ [ { "id": "HAMMER", "level": 2 } ], [ { "id": "SAW_W", "level": 1 } ] ],
"components": [ [ [ "2x4", 12 ] ], [ [ "nail", 10 ] ] ],
"pre_special": "check_empty",
Expand All @@ -1746,7 +1746,7 @@
"description": "Add Mattress to Bed Frame",
"category": "FURN",
"required_skills": [ [ "fabrication", 0 ] ],
"time": 5,
"time": "5 m",
"components": [ [ [ "mattress", 1 ], [ "down_mattress", 1 ] ] ],
"pre_terrain": "f_bed_frame",
"post_terrain": "f_bed"
Expand Down Expand Up @@ -2983,7 +2983,7 @@
"description": "Hang Hanging Meathook",
"category": "CONSTRUCT",
"required_skills": [ [ "fabrication", 1 ] ],
"time": 15,
"time": "15 m",
"qualities": [ [ { "id": "HAMMER", "level": 2 } ], [ { "id": "SCREW", "level": 1 } ] ],
"components": [ [ [ "grip_hook", 1 ] ], [ [ "chain", 1 ] ] ],
"pre_special": "check_support",
Expand Down Expand Up @@ -3050,7 +3050,7 @@
"//": "Step 1: start wall",
"category": "CONSTRUCT",
"required_skills": [ [ "fabrication", 3 ] ],
"time": 120,
"time": "120 m",
"qualities": [ [ { "id": "SMOOTH", "level": 1 } ] ],
"components": [
[ [ "adobe_brick", 10 ] ],
Expand All @@ -3067,7 +3067,7 @@
"//": "Step 2: finish wall",
"category": "CONSTRUCT",
"required_skills": [ [ "fabrication", 3 ] ],
"time": 120,
"time": "120 m",
"qualities": [ [ { "id": "SMOOTH", "level": 1 } ] ],
"components": [
[ [ "adobe_brick", 10 ] ],
Expand Down
8 changes: 4 additions & 4 deletions data/json/recipes/ammo/rifle.json
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@
"skill_used": "fabrication",
"difficulty": 5,
"skills_required": [ "gun", 5 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 4 ] ],
"charges": 1,
Expand All @@ -402,7 +402,7 @@
"skill_used": "fabrication",
"difficulty": 7,
"skills_required": [ "gun", 7 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 4 ] ],
"charges": 1,
Expand All @@ -422,7 +422,7 @@
"skill_used": "fabrication",
"difficulty": 4,
"skills_required": [ "gun", 4 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 4 ] ],
"charges": 1,
Expand All @@ -442,7 +442,7 @@
"skill_used": "fabrication",
"difficulty": 4,
"skills_required": [ "gun", 4 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 4 ] ],
"charges": 1,
Expand Down
20 changes: 10 additions & 10 deletions data/json/recipes/ammo/shot.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"skill_used": "fabrication",
"difficulty": 2,
"skills_required": [ "gun", 1 ],
"time": 3000,
"time": "30 s",
"book_learn": [ [ "recipe_bullets", 2 ], [ "manual_shotgun", 2 ] ],
"charges": 1,
"reversible": true,
Expand All @@ -123,7 +123,7 @@
"skill_used": "fabrication",
"difficulty": 2,
"skills_required": [ "gun", 1 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 1 ], [ "manual_shotgun", 1 ] ],
"charges": 1,
Expand All @@ -140,7 +140,7 @@
"skill_used": "fabrication",
"difficulty": 2,
"skills_required": [ "gun", 1 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 3 ], [ "manual_shotgun", 3 ] ],
"charges": 1,
Expand All @@ -157,7 +157,7 @@
"skill_used": "fabrication",
"difficulty": 2,
"skills_required": [ "gun", 1 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 4 ], [ "manual_shotgun", 4 ] ],
"charges": 1,
Expand All @@ -174,7 +174,7 @@
"skill_used": "fabrication",
"difficulty": 3,
"skills_required": [ "gun", 1 ],
"time": 2000,
"time": "20 s",
"batch_time_factors": [ 60, 5 ],
"book_learn": [ [ "recipe_bullets", 3 ], [ "manual_shotgun", 3 ] ],
"charges": 1,
Expand All @@ -188,7 +188,7 @@
"type": "recipe",
"copy-from": "bp_shot_00",
"book_learn": [ [ "survival_book", 1 ], [ "mag_survival", 1 ] ],
"time": 4000,
"time": "40 s",
"tools": [ [ [ "press_dowel", -1 ] ] ],
"components": [ [ [ "chem_black_powder", 6 ] ] ]
},
Expand All @@ -198,7 +198,7 @@
"type": "recipe",
"copy-from": "bp_shot_bird",
"book_learn": [ [ "survival_book", 1 ], [ "mag_survival", 1 ] ],
"time": 4000,
"time": "40 s",
"tools": [ [ [ "press_dowel", -1 ] ] ],
"components": [ [ [ "chem_black_powder", 3 ] ] ]
},
Expand All @@ -208,7 +208,7 @@
"type": "recipe",
"copy-from": "bp_shot_dragon",
"book_learn": [ [ "survival_book", 1 ], [ "mag_survival", 1 ] ],
"time": 4000,
"time": "40 s",
"tools": [ [ [ "press_dowel", -1 ] ] ],
"components": [ [ [ "chem_black_powder", 3 ] ], [ [ "magnesium", 5 ] ] ]
},
Expand All @@ -218,7 +218,7 @@
"type": "recipe",
"copy-from": "bp_shot_slug",
"book_learn": [ [ "survival_book", 1 ], [ "mag_survival", 1 ] ],
"time": 4000,
"time": "40 s",
"using": [ [ "ammo_bullet", 20 ], [ "ammo_shot", 1 ] ],
"tools": [
[ [ "press_dowel", -1 ] ],
Expand All @@ -233,7 +233,7 @@
"type": "recipe",
"copy-from": "bp_shot_scrap",
"book_learn": [ [ "survival_book", 1 ], [ "mag_survival", 1 ] ],
"time": 4000,
"time": "40 s",
"tools": [ [ [ "press_dowel", -1 ] ] ],
"components": [
[ [ "chem_black_powder", 6 ] ],
Expand Down
12 changes: 6 additions & 6 deletions data/json/recipes/recipe_vehicle.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"subcategory": "CSC_OTHER_VEHICLE",
"skill_used": "fabrication",
"difficulty": 3,
"time": 120000,
"time": "20 m",
"book_learn": [ [ "textbook_fabrication", 5 ], [ "textbook_carpentry", 5 ] ],
"qualities": [ { "id": "HAMMER", "level": 1 } ],
"using": [ [ "sewing_standard", 100 ] ],
Expand Down Expand Up @@ -250,7 +250,7 @@
"subcategory": "CSC_OTHER_PARTS",
"skill_used": "mechanics",
"difficulty": 5,
"time": 180000,
"time": "30 m",
"reversible": true,
"autolearn": false,
"book_learn": [ [ "textbook_mechanics", 5 ], [ "manual_mechanics", 5 ], [ "textbook_fabrication", 5 ] ],
Expand Down Expand Up @@ -369,7 +369,7 @@
"subcategory": "CSC_OTHER_VEHICLE",
"skill_used": "fabrication",
"difficulty": 3,
"time": 6000,
"time": "1 m",
"reversible": true,
"autolearn": true,
"qualities": [ { "id": "HAMMER", "level": 2 }, { "id": "SAW_W", "level": 1 } ],
Expand All @@ -382,7 +382,7 @@
"subcategory": "CSC_OTHER_VEHICLE",
"skill_used": "fabrication",
"difficulty": 4,
"time": 30000,
"time": "5 m",
"autolearn": true,
"tools": [ [ [ "mold_plastic", -1 ] ], [ [ "surface_heat", 50, "LIST" ] ] ],
"components": [ [ [ "plastic_chunk", 50 ] ] ]
Expand All @@ -394,7 +394,7 @@
"subcategory": "CSC_OTHER_VEHICLE",
"skill_used": "fabrication",
"difficulty": 2,
"time": 30000,
"time": "5 m",
"autolearn": true,
"qualities": [ { "id": "HAMMER", "level": 2 }, { "id": "SAW_W", "level": 1 } ],
"using": [ [ "sewing_standard", 100 ] ],
Expand All @@ -407,7 +407,7 @@
"subcategory": "CSC_OTHER_VEHICLE",
"skill_used": "fabrication",
"difficulty": 1,
"time": 500,
"time": "5 s",
"reversible": true,
"autolearn": true,
"qualities": [ { "id": "HAMMER", "level": 2 }, { "id": "SAW_W", "level": 1 } ],
Expand Down

0 comments on commit 2231d2d

Please sign in to comment.