Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution_booklet Errata from Alex Durie #256

Merged

Conversation

VVitale
Copy link
Collaborator

@VVitale VVitale commented Mar 5, 2019

No description provided.

@VVitale VVitale requested a review from giovannipizzi March 5, 2019 15:21
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #256 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #256   +/-   ##
========================================
  Coverage    62.04%   62.04%           
========================================
  Files           29       29           
  Lines        17134    17134           
========================================
  Hits         10631    10631           
  Misses        6503     6503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c25ea...aafe077. Read the comment docs.

@mostofi
Copy link
Member

mostofi commented Mar 5, 2019

Thanks to Alex for the careful reading of this. Just one thing: I'd usually write "ab initio" (no hyphen). Whether you italicise it is a matter of personal preference.

@VVitale
Copy link
Collaborator Author

VVitale commented Mar 5, 2019

Yes me too. Not sure why I used the hyphen in that paragraph.

@giovannipizzi giovannipizzi merged commit a9c0131 into wannier-developers:develop Apr 3, 2019
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
…n_booklet

Solution_booklet Errata from Alex Durie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants