Fix guiding center gamma point bug #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #223 +/- ##
===========================================
+ Coverage 61.31% 62.05% +0.73%
===========================================
Files 29 29
Lines 17129 17136 +7
===========================================
+ Hits 10503 10634 +131
+ Misses 6626 6502 -124
Continue to review full report at Codecov.
|
giovannipizzi
requested changes
Dec 21, 2018
src/disentangle.F90
Outdated
| @@ -533,7 +533,8 @@ subroutine internal_find_u_gamma() | |||
|
|
|||
| u_opt_r(:, :) = real(u_matrix_opt(1:ndimwin(1), 1:num_wann, 1), dp) | |||
|
|
|||
| a_matrix_r(:, :) = real(a_matrix(:, :, 1), kind=dp) | |||
| write (77, *) size(a_matrix_r, 1), size(a_matrix, 1) | |||
There was a problem hiding this comment.
Probably this write is a leftover?
| @@ -0,0 +1 @@ | |||
| 21 30 | |||
There was a problem hiding this comment.
Probably this file is not needed and can be removed?
giovannipizzi
approved these changes
Dec 21, 2018
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Fix guiding center gamma point bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #222 Also adds regression test for this bug