Added pre-commit hooks to fix indentation and trailing whitespace #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of warnings yet due to too long lines, above 132 chars.
Now there is no warning anymore from fprettify
(This is a re-application of what I did in ddb2ef9 after merging the recent PRs)
Codecov Report
@@ Coverage Diff @@
## develop #203 +/- ##
===========================================
- Coverage 61.01% 60.96% -0.05%
===========================================
Files 29 29
Lines 16933 16961 +28
===========================================
+ Hits 10331 10340 +9
- Misses 6602 6621 +19
Continue to review full report at Codecov.
|
Merged
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…ndent_from_develop Added pre-commit hooks to fix indentation and trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
fprettifycode by P. Seewald. This fixes #190This is a big PR because it touches almost every file, but the relevant commits to check would be ddb2ef9 and 6ef21e4 for the manual fixes to long lines, and the ones that add the pre-commit configuration.
Note that the wiki with the contributors guide is already updated to explain how to install and use the prettifier and install the git hooks.