Fixing the logic for the SCDM method with guiding centres and constrained centres in SLWF #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntres for SLWF. Also, some minor changes in parameters.F90 (printing more clear error messages for the SLWF method).
Codecov Report
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 61.01% 61.01% +<.01%
===========================================
Files 29 29
Lines 16930 16933 +3
===========================================
+ Hits 10329 10331 +2
- Misses 6601 6602 +1
Continue to review full report at Codecov.
|
giovannipizzi
approved these changes
Oct 5, 2018
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Fixing the logic for the SCDM method with guiding centres and constrained centres in SLWF Fixes wannier-developers#201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, some minor changes in parameters.F90 (printing more clear error messages for the SLWF method).