Fix a few stylistic issues with the new parallel code #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`param_read` is indeed called already inside a `if (on_root)` so these checks were not needed. Also added a comment at the top stating that the function should be called only from one (root) node.
Codecov Report
@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
+ Coverage 57.99% 57.99% +<.01%
===========================================
Files 27 27
Lines 16051 16052 +1
===========================================
+ Hits 9309 9310 +1
Misses 6742 6742
Continue to review full report at Codecov.
|
The current coverage is < 70% (codecov min default) so we get a lot of "failures". Setting the warning to when the failure is below <30% that should not trigger the 'failed' state.
jryates
approved these changes
Jun 21, 2018
3 tasks
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…parallel_stylistic Fix a few stylistic issues with the new parallel code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #128
comms.F90moved to main folderparam_read