Avoid subtracting num_exclude_bands twice in library mode #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
approved these changes
Mar 21, 2018
Codecov Report
@@ Coverage Diff @@
## develop #170 +/- ##
===========================================
- Coverage 57.41% 57.41% -0.01%
===========================================
Files 27 27
Lines 15573 15572 -1
===========================================
- Hits 8942 8941 -1
Misses 6631 6631
Continue to review full report at Codecov.
|
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…ands_library Avoid subtracting num_exclude_bands twice in library mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the problem in library mode where num_exclude_bands was subtracted twice.
This was introduced in #19 trying to fix the fact
num_bandswasn't defined in library mode.The solution of #19 was to subtract num_exclude_bands in
param_read, butparam_readis run twice (inwannier_setupandwannier_run). Now, we set num_bands to the correct value (already subtracted) inwannier_lib.f90, but we do it before callingparam_read, so this should be a fix both to the current problem and to the original problem of #19.