-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for External Release Repository #114
Add Support for External Release Repository #114
Conversation
This adds a feature where we can publish the release to an external repository, a good use case on this is when you have a private repository and wish to publish binaries to the public.
@@ -71,6 +71,10 @@ inputs: | |||
description: 'Upload binaries to specified release page that indicated by release name.' | |||
required: false | |||
default: '' | |||
release_repo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add this feature in README.md as well? If you'll use it in production, I'll merge it and release a new version then. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx for the heads-up @wangyoucao577, are you able to test-run this before building a new release?
I added it to the documentation but I prefer leaving it out of the YAML examples - most organizations will probably release on the same repository, those that need to release on a different repo will probably dig and read the doc instinctively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test it. So it'll be great if you can help to test it before I release the version!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a real-life example, updated the PR's comment with links to the repositories. Thanks @wangyoucao577 for the support!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have merged this PR, could you please help to test it with wangyoucao577/go-release-action@master
? If it works as expect, I'll release a new version for it. Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good:
- https://github.com/serafdev/go-release-action-test-private/releases/tag/v0.0.1-alpha.2
- https://github.com/serafdev/go-release-action-test-public/releases/tag/v0.0.1-alpha.2
Link to the pipeline: https://github.com/serafdev/go-release-action-test-private/actions/runs/4397561683
Thanks bud for your time! 🥇
Referencing the comment on this PR: wangyoucao577/go-release-action#114 (comment)
This adds a feature where we can publish the release to an external repository, a good use case on this is when you have a private repository and wish to publish binaries to the public.
Added 2 test repos as an example:
Uploaded a dummy file (
go.mod
, can be found in the second link above) to test the supported flags from https://github.com/wangyoucao577/assets-uploader: