Accept minor release version string as goversion #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! Would you please also add a test here to make sure it works well? https://github.com/cetteup/go-release-action/blob/49e097e3fbdce35f1cd04f70b403e891ccac745d/.github/workflows/autotest.yml#L82 |
|
Of course! I was looking for tests, but did not check the workflows. My bad. I added a minor version to the |
cetteup
force-pushed
the
feat/go-minor-version
branch
from
09a5bb6
to
17ba31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to use a minor release version right now is to pass the download URL for the release. Meaning you lose the benefit of
setup-go.shautomatically adding the architecture it needs.These changes would allow users to simply specify
1.19.5instead of having to pass the URL - without changing any of the existing options.