Each time the script is executed, focus on the next overlapping line #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiredPlanck
pushed a commit
to WhiredPlanck/Aegisub
that referenced
this pull request
Jan 3, 2025
* Bump boost to 1.83 * Switch to building as C++20 Co-authored-by: Ryan Lucia <[email protected]> * Fix many warnings * Rip out boost::locale and just use ICU directly * Fix * Replace boost::filesystem with std::filesystem * Fix * Addditional c++ modernization * Use string_view all over the place and rip out more boost stuff * Simply BOM handling in charset conversions * libaegisub: fix dispatch types * Fix * Bump subprojects * Reorganize tests build file * Fix remaining compilation errors on Linux * Rip out the last bits of boost::filesystem * Remove remaining uses of boost string joins * Fix some errors introduced with refactors * Revert "Simply BOM handling in charset conversions" This reverts commit 2e6b26d. Taking out the BOM handling broke tests, so it'll probably break more stuff. * Bring back IconvWrapper::RequiredBufferSize This partially reverts 62befa9 . This function is actually used in charset_conv_win.cpp * Fix ifind after moving to ICU The previous logic didn't check if the match was on parts of decomposed characters, so it also failed the corresponding test. * Remove incorrect karaoke_matcher test This was clearly incorrect and probably just unfinished. * Remove leftover boost::locale code * Move iconv include to charset_conv.h On newer mac sdks iconv_t is defined differently, so it's harder to just have a typedef for it. * Fix compilation on arm64 mac wx uses a different string implementation here, and utf8_string() doesn't exist there. * Fix luajit dependency in luabins project Since luajit always first tried using dependency(), further calls of dependency() will also always return system luajit. meson.override_dependency() won't work. This makes luabins link system luajit where it's available while aegisub itself uses the subproject's luajit, which causes all kinds of fun issues and definitely didn't baffle me four hours... The added solution for this is horribly ugly (and also has problems when reconfiguring...) but it's the only one I found that works. Maybe it's better to always require interal luajit after all, or make the user choose with a meson option? * Fix locale initialization Previously this would fail on startup because the automation menu uses boost::locale::comparator. ... Or maybe the locale init change should just be reverted entirely? Or it should be something different? I don't really know. * Revert "Fix luajit dependency in luabins project" This reverts commit 340fb9c. * Fix luajit dependency in luabins project, take 2 Thinking about it some more, just copying the detection logic is probably the lesser evil here. * Fix agi::split_iterator after refactor is_end being removed caused it to not output an empty segment at the end if the input ends with a delimiter, but existing usages relied on it doing that. * Fix style parsing after refactor * Fix tons of implicit this captures * Enable CI to test * Update deprecated hunspell usage * Fix tests compilation on mac * Make sure wx subproject builds with c++14 * Fix compilation on Windows * Revert "Bring back IconvWrapper::RequiredBufferSize" This reverts commit 04f4b26. * Pin libass wrap for now Apparently dependency('iconv') breaks when iconv is overridden?? * Fix compilation with wx 3.0 * Fix startup crash on Windows windows.h was defining the ERROR macro, which shadowed the DialogueTokenType enum variant, which broke the lexer construction. * Fix SplitText ICU logic Include UBRK_WORD_IDEO and check the entire rules vec. This now matches the logic of boost::locale. * Add test for character_count with \N and friends * Fix ass_dialogue parsing after refactor * Revert "Pin libass wrap for now" This reverts commit 3802bb7. * Remove iconv's stdbool.h This was breaking things (libass) and doesn't seem to be needed any more. * Revert changes to to_wx These broke some things, in particular FromUTF8Unchecked seems to not like empty strings. Probably safer to just revert. * Fix kara replacer after refactor * Fix karaoke timing mode after refactor * Revert "Enable CI to test" This reverts commit 256cbeb. --------- Co-authored-by: Ryan Lucia <[email protected]> Co-authored-by: Thomas Goyne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time this script is executed, the currently active subtitle is set to the next closest overlapping line after the current line.
If there are no overlapping lines after the current line, the currently active subtitle is set to the first overlapping line from the beginning of the subtitles.
If no overlapping lines are found in the entire subtitle file, a prompt dialog box will pop up.