feat: use props to pass homeLink

Signed-off-by: SuZhou-Joe <[email protected]>
wanglam · Apr 23, 2024 · f47bd9e · f47bd9e
1 parent 05c583c
commit f47bd9e
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/src/plugins/home/public/application/components/home_app.js b/src/plugins/home/public/application/components/home_app.js
@@ -61,16 +61,27 @@ const renderTutorialDirectory = (props) => {
       addBasePath={addBasePath}
       openTab={props.match.params.tab}
       isCloudEnabled={isCloudEnabled}
+      homeLink={props.homeLink}
     />
   );
 };
 
 export function ImportSampleDataApp() {
+  const { application } = getServices();
   return (
     <I18nProvider>
       <Router>
         <Switch>
-          <Route path="*" exact={true} component={renderTutorialDirectory} />
+          <Route
+            path="*"
+            exact={true}
+            component={(props) =>
+              renderTutorialDirectory({
+                ...props,
+                homeLink: application.getUrlForApp('home'),
+              })
+            }
+          />
         </Switch>
       </Router>
     </I18nProvider>

diff --git a/src/plugins/home/public/application/components/tutorial_directory.js b/src/plugins/home/public/application/components/tutorial_directory.js
@@ -93,7 +93,8 @@ class TutorialDirectoryUi extends React.Component {
 
   async componentDidMount() {
     this._isMounted = true;
-    const { chrome, homeLink } = getServices();
+    const { chrome } = getServices();
+    const { homeLink } = this.props;
 
     chrome.setBreadcrumbs([
       {

diff --git a/src/plugins/home/public/application/opensearch_dashboards_services.ts b/src/plugins/home/public/application/opensearch_dashboards_services.ts
@@ -77,7 +77,6 @@ export interface HomeOpenSearchDashboardsServices {
   dataSource?: DataSourcePluginStart;
   workspaces: WorkspacesStart;
   sectionTypes: SectionTypeService;
-  homeLink?: string;
 }
 
 let services: HomeOpenSearchDashboardsServices | null = null;

diff --git a/src/plugins/home/public/plugin.ts b/src/plugins/home/public/plugin.ts
@@ -157,9 +157,7 @@ export class HomePublicPlugin
       navLinkStatus: AppNavLinkStatus.hidden,
       mount: async (params: AppMountParameters) => {
         const [coreStart] = await core.getStartServices();
-        setCommonService({
-          homeLink: coreStart.application.getUrlForApp('home'),
-        });
+        setCommonService();
         coreStart.chrome.docTitle.change(
           i18n.translate('home.tutorialDirectory.featureCatalogueTitle', {
             defaultMessage: 'Add sample data',