Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use setTimeout to run the next test loop #3

Merged
merged 1 commit into from
Apr 13, 2015

Conversation

tyoshino
Copy link
Contributor

This code is for preventing stack overflow, but on Chrome this induced 4-5 ms delay for each test run. We need to be careful not to grow stack.

This code is for preventing stack overflow, but on Chrome this induced 4-5 ms delay for each test run. We need to be careful not to grow stack.
@tyoshino
Copy link
Contributor Author

In response to whatwg/streams#320 (comment)

wanderview pushed a commit that referenced this pull request Apr 13, 2015
Don't use setTimeout to run the next test loop
@wanderview wanderview merged commit 0b17959 into wanderview:gh-pages Apr 13, 2015
@wanderview
Copy link
Owner

Thanks! This significantly changes the results. I'll try to make a new tab in the spreadsheet to capture this.

@tyoshino tyoshino deleted the nosettimeout-1 branch April 14, 2015 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants