-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weave): link artifact references in weave trace #2920
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0faf2ec1d283ca1f85f6da825552ca0476867618 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the registry/model-registry url changes. Recommended some minor changes
weave-js/src/components/PagePanelComponents/Home/Browse2/url.ts
Outdated
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse2/url.ts
Outdated
Show resolved
Hide resolved
Trace server changes pulled out (with minor tweaks) as #3484 |
FE changes were updated and merged as #3500 |
Description
https://wandb.atlassian.net/browse/WB-21724
Building on @levinandrew's PR
New loom with feedback:
https://www.loom.com/share/e25073c52f5c4f73bb523e043b1672ec?sid=6b3d6655-da3f-4645-9543-a04d54d0b224
old loom:https://www.loom.com/share/056ae7450d064784b6c8b3a79dfcbc97?sid=1ed27f9c-d9fe-42a8-b2bc-0a93cb676a41Testing
locally. Note, you need to have a
http://localhost:9000/orgs/gr-org/registry/
for example and it will auto set up Registries of type model)Test code example:
TODO: Test on QA