-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WB-8710] Support logging from multiple processes with wandb-service #3285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3285 +/- ##
==========================================
+ Coverage 81.32% 81.38% +0.05%
==========================================
Files 232 232
Lines 28304 28320 +16
==========================================
+ Hits 23019 23047 +28
+ Misses 5285 5273 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few minor points.
): | ||
if cls._is_attaching: | ||
message = f"Trying to attach `{func.__name__}` while in the middle of attaching `{cls._is_attaching}`" | ||
raise RuntimeError(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a yea
test to check this logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is hard to do that since we need a Run
method that calls another Run
method while we are doing the attaching... it means to break the current code... I could override some Run
function don't know if it has a lot of value...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then could this ever happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah if for example i add:
@Attach._attach
def new_func(self, ...):
self.log(....)
and someone trying to use the new function in and attached process, it should fail... but it means that we wrote a bad code... I guess we need a way to test all the new methods in functional tests... (with attach)
Co-authored-by: Dmitry Duev <[email protected]>
Fixes WB-8710
Description
What does the PR do?
_attach_pid
to indicate current process and save_init_pid
for the source pidTesting
How was this PR tested?
Checklist