Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels as links #29

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Labels as links #29

merged 4 commits into from
Apr 2, 2021

Conversation

jcsrb
Copy link
Contributor

@jcsrb jcsrb commented Mar 30, 2021

Allow for creation of a tags instead of span when a url is added for each node in the dataset
this allows for standard click/middleclick experience which otherwise needs onEventClick handler

@walterra
Copy link
Owner

walterra commented Apr 2, 2021

That's a great suggestion, thank you! Can you remove the .tool-versions from .gitignore please that looks unrelated.

@jcsrb
Copy link
Contributor Author

jcsrb commented Apr 2, 2021

@walterra updated

thanks for considering it
I started a new fork over at https://github.com/vizlegal/d3-milestones , as I add more things if they make sense in the main version I will open PRs - if something doesn't fit the vision feel free do close PRs

@walterra
Copy link
Owner

walterra commented Apr 2, 2021

Thanks for the update! Glad you like the project, looking forward to your suggestions!

@walterra walterra self-requested a review April 2, 2021 19:59
@walterra walterra added this to the 1.1.0 milestone Apr 2, 2021
@walterra walterra merged commit a3f08ae into walterra:main Apr 2, 2021
@walterra
Copy link
Owner

walterra commented Apr 2, 2021

Published v1.1.0 with support for links https://www.npmjs.com/package/d3-milestones

@jcsrb jcsrb deleted the labels-as-links branch April 2, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants