Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to toggle show/hide detailed output of each stage #11

Open
mizzy opened this issue Feb 17, 2016 · 6 comments
Open

Enable to toggle show/hide detailed output of each stage #11

mizzy opened this issue Feb 17, 2016 · 6 comments
Assignees

Comments

@mizzy
Copy link
Contributor

mizzy commented Feb 17, 2016

Wercker hide detailed output of each step by default and show only detailed output of failed steps.

You can see this behaviour:
https://app.wercker.com/#buildstep/56b7e9a849c60cc8633f64ca

I'd like walter-server to behave as same as Wercker.

@gerryhocks Can you implement this, please ?

@gerryhocks
Copy link
Contributor

Good idea! I will implement it.

gerryhocks added a commit that referenced this issue Feb 23, 2016
…ult, ensure browser back buttons worK)
@gerryhocks
Copy link
Contributor

I've added a expand and collapse button to each stage's output (if there is output), and made Failed output visible by default.

Could you please test this change?

@mizzy
Copy link
Contributor Author

mizzy commented Feb 25, 2016

Thanks! I will check it.

@mizzy
Copy link
Contributor Author

mizzy commented Feb 29, 2016

LGTM! Thanks a lot!

@mizzy mizzy closed this as completed Feb 29, 2016
@mizzy mizzy reopened this Feb 29, 2016
@mizzy
Copy link
Contributor Author

mizzy commented Feb 29, 2016

It seems that there are some delay to toggle the output when clicking stage names of parallel stages.

You can see it with this page.
http://128.199.251.31:8080/#project=mizzy%2Fwalter-test&report=20

If you click "Passed echo bar" or "Passed echo baz", you will wait for 5 secods or more to see showing/hiding the output.

@gerryhocks Could you check this please ?

@gerryhocks
Copy link
Contributor

I see the issue. Will fix.

gerryhocks added a commit that referenced this issue Feb 29, 2016
…d sample data generator to include stage names with spaces in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants