This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Validate contextPath state on store #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,14 +37,14 @@ var ServerMarshal = Thorax.ServerMarshal = { | |||
| if (_.isArray(attributes) && !_.isString(attributeIds) && !attributes.toJSON) { | |||
| if (attributes.length) { | |||
| cache[name] = _.map(attributes, function(value, key) { | |||
| return lookupValue(value, attributeIds[key], contextPath); | |||
| return lookupValue(value, attributeIds[key], contextPath, data.view, data.root); | |||
There was a problem hiding this comment.
Should we just pass data as a third argument instead of its three attributes?
There was a problem hiding this comment.
This matches the data structure that is passed to handlebars helpers, which is the primary use case for this, so the nesting felt like the proper thing to do in this particular case.
Ensure that ServerMarshal.store generated lookup paths refer to the same object that is passed in. This prevents us from running into issues on the client where there is no hope of a safe recovery.
|
@candid went ahead and made the data object optional. |
kpdecker
added a commit
that referenced
this pull request
Apr 1, 2014
Validate contextPath state on store
|
Released in v3.0.0-alpha.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server marshal should validate that the context path value is correct on save to ensure that lookup will occur safely when restoring on the client side.